Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: skip test files in coverage, use SafeL2 contract for coverage calculation #674

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Chore: skip test files in coverage, use SafeL2 contract for coverage calculation #674

merged 1 commit into from
Oct 9, 2023

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Oct 9, 2023 •
edited
Loading

This PR:

  • Skips test files that were introduced during work on 1.4.1 and 1.5.0 and negatively affected test coverage
  • Includes the environment variable used for Safe Contract instance under testing to the sample env file
  • Use SafeL2 contract for the coverage test

@coveralls
Copy link

coveralls commented Oct 9, 2023 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 6458179212

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.3%) to 95.177%
Totals Coverage Status
Change from base Build 6456165180: 2.3%
Covered Lines: 367
Relevant Lines: 376
💛 - Coveralls

akshay-ap
akshay-ap approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@akshay-ap akshay-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmv08 mmv08 changed the title Chore: skip test files in coverage Chore: skip test files in coverage, use SafeL2 contract for coverage Oct 9, 2023
@mmv08 mmv08 changed the title Chore: skip test files in coverage, use SafeL2 contract for coverage Chore: skip test files in coverage, use SafeL2 contract for coverage calculation Oct 9, 2023
@mmv08 mmv08 merged commit be0c330 into main Oct 9, 2023
15 checks passed
@mmv08 mmv08 deleted the chore/coverage-skip-test branch October 9, 2023 14:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akshay-ap akshay-ap akshay-ap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmv08 @coveralls @akshay-ap